mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.
Date Thu, 19 Apr 2018 22:32:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review201573
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/http_proxy.cpp
Lines 156-157 (patched)
<https://reviews.apache.org/r/66440/#comment282889>

    We're unlikely to ever make this change, so you can probably remove this TODO.


- Joseph Wu


On April 9, 2018, 3:09 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 3:09 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-8675
>     https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http_proxy.cpp 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message