mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.
Date Thu, 19 Apr 2018 20:01:18 GMT


> On April 17, 2018, 4:24 p.m., Greg Mann wrote:
> > src/tests/authorization_tests.cpp
> > Line 1979 (original), 1979 (patched)
> > <https://reviews.apache.org/r/66532/diff/2/?file=1996775#file1996775line1979>
> >
> >     Could you also add an end-to-end test of authorization for these operations?

Sure. Do you have an example or existing test to add this?


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review201362
-----------------------------------------------------------


On April 10, 2018, 12:24 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> -----------------------------------------------------------
> 
> (Updated April 10, 2018, 12:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
>     https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message