mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
Date Thu, 19 Apr 2018 16:24:46 GMT


> On April 13, 2018, 9:43 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 455-459 (patched)
> > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line455>
> >
> >     Is this enforced somewhere in validation code? Can we check for expected behavior
when a GROW/SHRINK operation is submitted for a MOUNT volume, rather than simply returning?
> 
> Zhitao Li wrote:
>     I added validation in r/66050 so we drop shrink volume operation on MOUNT. There
is no logical path for triggering `GROW` on `MOUNT` disk type so I'm not writing validation.
>     
>     For testing, we can either keep the current structure and check that `GROW`/`SHRINK`
do not work on `MOUNT` (operation will be dropped), or take Chun's suggestion to not test
them for `MOUNT`. Please let me know.

I think this will be the only test case which needs to skip `MOUNT`. It also makes some sense
because there is no logical starting point for a framework to even construct a `GROW_VOLUME`
message for `MOUNT`.

I still feel that the handling here could be better. we can discuss on next patch revision.


> On April 13, 2018, 9:43 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 541-542 (patched)
> > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line541>
> >
> >     Is this `Future` necessary? Since the task consumes the volume, it may be sufficient
to await on the task status updates?

Yes this is necessary if we do not launch task in this test. we need to reliably know that
`Allocator::updateAllocation` is called from master, and this message happens before that,
so this `Future` ensures allocator has properly processed all operation conversions and next
offer will contain the host and updated resources.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201109
-----------------------------------------------------------


On April 11, 2018, 2:19 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 2:19 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message