mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 66706: Handled failing to create the executor sandbox.
Date Thu, 19 Apr 2018 13:58:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66706/#review201512
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 2994 (patched)
<https://reviews.apache.org/r/66706/#comment282784>

    Kill this newline.


- Qian Zhang


On April 19, 2018, 6:12 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66706/
> -----------------------------------------------------------
> 
> (Updated April 19, 2018, 6:12 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8585
>     https://issues.apache.org/jira/browse/MESOS-8585
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the agents adds a new executor, creating the sandbox might
> fail (most commonly because the requested task user is not present
> on the agent). Rather than crashing the agent with a `CHECK`,
> we report a `TASK_DROPPED` status update. This makes the behavior
> more consistent with the nested containers API, which also reports
> an error in this case.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp d00c7b2e2466fd1de71e9e55343a27d3808bde3e 
>   src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 
> 
> 
> Diff: https://reviews.apache.org/r/66706/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message