> On April 19, 2018, 12:25 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/manager.cpp
> > Line 160 (original), 161 (patched)
> > <https://reviews.apache.org/r/66310/diff/4/?file=2005447#file2005447line161>
> >
> > `Owned<Registrar>&& _registrar`?
https://reviews.apache.org/r/66309/#comment_rc282702-201502
> On April 19, 2018, 12:25 a.m., Chun-Hung Hsiao wrote:
> > src/slave/slave.cpp
> > Lines 8869-8871 (patched)
> > <https://reviews.apache.org/r/66310/diff/4/?file=2005448#file2005448line8869>
> >
> > The current implementation makes this assertion never fail ;)
That's exactly why this is an assertion, not a branch :D
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66310/#review201475
-----------------------------------------------------------
On April 19, 2018, 2:28 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66310/
> -----------------------------------------------------------
>
> (Updated April 19, 2018, 2:28 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to support recovering resource provider manager information
> in the future, we need to adjust the construction of the manager to be
> able to consume a registrar.
>
> This patch lays the groundwork by adjusting interfaces and their
> usage; we will make use of the passed on information in a following
> patch.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.hpp bc017fa3998b780cec82718cabe2a8b470a66db2
> src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a
> src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5
> src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea
>
>
> Diff: https://reviews.apache.org/r/66310/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|