mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.
Date Thu, 19 Apr 2018 07:33:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66708/#review201499
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66704, 66705, 66706, 66707, 66708]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 18, 2018, 10:13 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66708/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 10:13 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8585
>     https://issues.apache.org/jira/browse/MESOS-8585
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored how the agent sends a TASK_DROPPED status update to
> remove code duplication. This also makes the agent consistently
> send the executor ID in all these status updates.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 
> 
> 
> Diff: https://reviews.apache.org/r/66708/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message