mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 66709: Windows: Fixed Ninja in Release configuration.
Date Thu, 19 Apr 2018 01:21:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66709/#review201492
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On April 18, 2018, 6:17 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66709/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 6:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Several third-party dependencies had TODOs to be resolved in order to
> build with `-DCMAKE_BUILD_TYPE=Release` with Ninja on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 4eba87fdbca6a0c337e94631409ae621839bc6f0 
> 
> 
> Diff: https://reviews.apache.org/r/66709/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> cmake .. -G Ninja -DENABLE_LIBEVENT=1 -DCMAKE_BUILD_TYPE=Release
> [20/20] Linking CXX executable src\mesos-agent.exe
> ```
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message