mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 66709: Windows: Fixed Ninja in Release configuration.
Date Thu, 19 Apr 2018 01:17:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66709/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
-------

Several third-party dependencies had TODOs to be resolved in order to
build with `-DCMAKE_BUILD_TYPE=Release` with Ninja on Windows.


Diffs
-----

  3rdparty/CMakeLists.txt 4eba87fdbca6a0c337e94631409ae621839bc6f0 


Diff: https://reviews.apache.org/r/66709/diff/1/


Testing
-------

```
cmake .. -G Ninja -DENABLE_LIBEVENT=1 -DCMAKE_BUILD_TYPE=Release
[20/20] Linking CXX executable src\mesos-agent.exe
```


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message