mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66700: Changed call from os::shell() to os::system().
Date Wed, 18 Apr 2018 22:16:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66700/#review201477
-----------------------------------------------------------



FAIL: Mesos binaries failed to build.

Reviews applied: `['66699', '66700']`

Failed command: `cmake.exe --build . --config Release -- /maxcpucount`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66700

Relevant logs:

- [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66700/logs/mesos-binaries-cmake-stdout.log):

```
       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\docker\mesos-docker-executor.vcxproj" (default target) (31) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\docker\mesos-docker-executor.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj" (default target) (18) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\master\mesos-master.vcxproj" (default target) (34) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\master\mesos-master.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (21) ->
         d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit':
destructor never returns, potential memory leak [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj]


       "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\jemalloc-5.0.1.vcxproj" (default target) (11) ->
       (CustomBuild target) -> 
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 9009. [D:\DCOS\mesos\3rdparty\jemalloc-5.0.1.vcxproj]

    358 Warning(s)
    1 Error(s)

Time Elapsed 00:23:36.56
```

- Mesos Reviewbot Windows


On April 18, 2018, 8:56 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66700/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 8:56 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The function os::shell is not implemented on Windows,
> making it necessary to either hide all calls behind a
> preprocessor macro or to avoid the function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/memory_profiler.cpp b2174ba8ce9f10b268736678e3d92b175f6d1247

> 
> 
> Diff: https://reviews.apache.org/r/66700/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message