mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66696: Updated Scheduler HTTP API doc for operation feedback.
Date Wed, 18 Apr 2018 21:51:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66696/#review201466
-----------------------------------------------------------




docs/scheduler-http-api.md
Lines 167-172 (original), 170-175 (patched)
<https://reviews.apache.org/r/66696/#comment282716>

    Let's add a blurb here on feedback for offer operations. Would be nice to explain that
LAUNCH and LAUNCH_GROUP operations will always receive task status updates, and other operations
with `id` field set will always receive operation updates.
    
    This might also be a good place to mention that right now, feedback is only available
for operations on RP resources? Unless there's a better place for that information.



docs/scheduler-http-api.md
Lines 378-383 (patched)
<https://reviews.apache.org/r/66696/#comment282706>

    Looks like this call doesn't have a `task_id` field, but it does have a `resource_provider_id`
field.



docs/scheduler-http-api.md
Lines 423 (patched)
<https://reviews.apache.org/r/66696/#comment282708>

    s/RECONCILE/RECONCILE_OPERATIONS/



docs/scheduler-http-api.md
Lines 426-428 (patched)
<https://reviews.apache.org/r/66696/#comment282707>

    This call requires the `Accept` header, right?



docs/scheduler-http-api.md
Lines 434-439 (patched)
<https://reviews.apache.org/r/66696/#comment282711>

    Should we include the `resource_provider_id` field here, since the MVP is RP resource-only?



docs/scheduler-http-api.md
Lines 455 (patched)
<https://reviews.apache.org/r/66696/#comment282712>

    Extra comma at the end of line.


- Greg Mann


On April 18, 2018, 8:36 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66696/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated Scheduler HTTP API doc for operation feedback.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md 3929c33781a152428338c4cdaf7dbc47da7c875e 
> 
> 
> Diff: https://reviews.apache.org/r/66696/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message