mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66163: Built storage local resource provider with CMake.
Date Wed, 18 Apr 2018 19:10:20 GMT


> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 387-390 (patched)
> > <https://reviews.apache.org/r/66163/diff/3/?file=1996903#file1996903line387>
> >
> >     Do you know which targets actually require `ENABLE_GRPC` set as a pre-processor
definition? Since it's new code being added, we should be able to resovle this TODO before
committing.
> 
> Chun-Hung Hsiao wrote:
>     For now it's just `src/resource_provider/local.cpp`. What's the best way to achieve
this? IMHO it's not that bad to make this global. ;)

Change
```
target_compile_definitions(mesos PUBLIC USE_CMAKE_BUILD_CONFIG)
```
to
```
target_compile_definitions(
  mesos
  PUBLIC USE_CMAKE_BUILD_CONFIG
  PRIVATE ENABLE_GRPC)
```

But yeah, we still have `add_definitions(-DUSE_SSL_SOCKET=1)`, so this can be a `TODO`.


> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote:
> > src/resource_provider/storage/CMakeLists.txt
> > Lines 18 (patched)
> > <https://reviews.apache.org/r/66163/diff/3/?file=1996906#file1996906line18>
> >
> >     Nit: I've been aligning the `###`... but I know it's that important.
> 
> Chun-Hung Hsiao wrote:
>     Oops sorry my bad.

Know it's _not_ that important (is what I meant to say)


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66163/#review201017
-----------------------------------------------------------


On April 16, 2018, 8:20 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66163/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 8:20 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
> 
> 
> Bugs: MESOS-8698
>     https://issues.apache.org/jira/browse/MESOS-8698
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds CMake rules for compiling necessary source code for
> building storage local resource provider and related tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d 
>   src/CMakeLists.txt 31af9eaf302122b844e7599944097ad1c3faae3a 
>   src/examples/CMakeLists.txt e85eed607715d2b3ee596c3c0b51f16682491900 
>   src/resource_provider/storage/CMakeLists.txt PRE-CREATION 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
> 
> 
> Diff: https://reviews.apache.org/r/66163/diff/4/
> 
> 
> Testing
> -------
> 
> `sudo make check` with CMake
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message