mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61118: Building gRPC support in libprocess with CMake.
Date Wed, 18 Apr 2018 19:02:19 GMT


> On April 12, 2018, 9:55 a.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt
> > Lines 91 (patched)
> > <https://reviews.apache.org/r/61118/diff/4/?file=1982733#file1982733line91>
> >
> >     I think this should instead be appended above. That is, after setting `GRPC_TESTS_PROTOS`,
do a `list(APPEND PROCESS_TESTS_SRC ${GRPC_TESTS_PROTOS})`, to be consistent with the rest.
> 
> Chun-Hung Hsiao wrote:
>     Since the files in `${GRPC_TESTS_PROTOS}` are generated files, should we put them
into `${PROCESS_TESTS_SRC}`?
> 
> Andrew Schwartzmeyer wrote:
>     I think so. They are required for the build, and the exist as byproducts of some
generation command, right? So they dependency graph should ensure that they get generated
before the test target is built. Maybe bbannier has thoughts on that?

Yeah, we're not changing the semantics of it by adding it to the `PROCESS_TESTS_SRC` variable,
since both variables are sent as the list of sources to the target. I mean, it's fine either
way, just seems cleaner IMHO to get everything into the one variable and have the target use
just it.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/#review201014
-----------------------------------------------------------


On April 16, 2018, 8:17 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61118/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 8:17 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
> 
> 
> Bugs: MESOS-7881
>     https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables CMake to build code for gRPC support in libprocess
> along with tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt 0ce7dac5deea94623530820d173ce3ffe5b42ea4 
>   3rdparty/libprocess/src/tests/CMakeLists.txt d624402bc9efb43a130a2afdf27cfc1aa69010e4

> 
> 
> Diff: https://reviews.apache.org/r/61118/diff/5/
> 
> 
> Testing
> -------
> 
> `sudo make check` with CMake
> `cd 3rdparty/libprocess/src/tests && make libprocess-tests && ./libprocess-tests`
> 
> 
> NOTE: Testing on Windowns is not done yet.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message