mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61096: Building gRPC with CMake.
Date Wed, 18 Apr 2018 18:54:43 GMT


> On April 12, 2018, 9:41 a.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 1012-1015 (patched)
> > <https://reviews.apache.org/r/61096/diff/6/?file=1996892#file1996892line1014>
> >
> >     As stated above, the probably won't work on Windows yet. Ths VS solutions generally
stick everything under `Debug` or `Release` folders, and it's done at build time, not configuration
time. It's super annoying.
> 
> Chun-Hung Hsiao wrote:
>     Temporarily disable the WIN32 build. Can you help me on this since I don't have an
available Windows machine to test the build? :(

That's fine, default it to disabled, add a TODO, and file an issue. We'll get back to it after
1.6.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201007
-----------------------------------------------------------


On April 16, 2018, 8:16 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 8:16 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
> 
> 
> Bugs: MESOS-7881
>     https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
>   3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2 
>   cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d 
>   src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc 
> 
> 
> Diff: https://reviews.apache.org/r/61096/diff/7/
> 
> 
> Testing
> -------
> 
> `sudo make check` with CMake
> 
> NOTE: Testing on Windowns is not done yet.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message