mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.
Date Wed, 18 Apr 2018 04:15:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review201384
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/main.cpp
Lines 369 (patched)
<https://reviews.apache.org/r/63370/#comment282604>

    Extra newline.


- Alexander Rukletsov


On April 18, 2018, 4:15 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 4:15 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7944
>     https://issues.apache.org/jira/browse/MESOS-7944
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
> 
> 
> Diffs
> -----
> 
>   src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d 
>   src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07 
>   src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea 
>   src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
>   src/slave/flags.cpp 4ea2286a6a874e6e7f473f97fb0431e17b19c1f8 
>   src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9 
> 
> 
> Diff: https://reviews.apache.org/r/63370/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message