-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66568/#review201351
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 4510 (patched)
<https://reviews.apache.org/r/66568/#comment282527>
Since the `createTaskStatus` helper takes an `Option<Reason> reason` and an `Option<string>
message`, let's just split this into two variables, e.g., `dropReason` and `dropMessage`.
similar to what we did elsewhere in the codebase, e.g., `default_executor.cpp`.
- Chun-Hung Hsiao
On April 17, 2018, 5 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66568/
> -----------------------------------------------------------
>
> (Updated April 17, 2018, 5 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
>
>
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These two operations are intended to be non-speculative eventually but
> are implemented as speculative right now. To avoid frameworks opt-in to
> dangerous behavior, we require that accept can only contain one
> `GROW_VOLUME` or `SHRINK_VOLUME` and no other operations.
>
> This is implemented by reuse existing code which already drops `LAUNCH`
> or `LAUNCH_GROUP` with proper reason and message.
>
>
> Diffs
> -----
>
> src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
>
>
> Diff: https://reviews.apache.org/r/66568/diff/2/
>
>
> Testing
> -------
>
> Behavior tested in https://reviews.apache.org/r/66569/.
>
>
> Thanks,
>
> Zhitao Li
>
>
|