mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.
Date Tue, 17 Apr 2018 17:00:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66568/
-----------------------------------------------------------

(Updated April 17, 2018, 10 a.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
-------

Drop all operations if combined with GROW/SHRINK.


Summary (updated)
-----------------

Dropped combined operations with GROW and SHRINK volumes.


Bugs: MESOS-4965
    https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description (updated)
-------

These two operations are intended to be non-speculative eventually but
are implemented as speculative right now. To avoid frameworks opt-in to
dangerous behavior, we require that accept can only contain one
`GROW_VOLUME` or `SHRINK_VOLUME` and no other operations.

This is implemented by reuse existing code which already drops `LAUNCH`
or `LAUNCH_GROUP` with proper reason and message.


Diffs (updated)
-----

  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 


Diff: https://reviews.apache.org/r/66568/diff/2/

Changes: https://reviews.apache.org/r/66568/diff/1-2/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message