mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 66670: Ensured that `wait()` and `destroy()` return the same result. (WIP)
Date Tue, 17 Apr 2018 15:23:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66670/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.


Bugs: MESOS-8713
    https://issues.apache.org/jira/browse/MESOS-8713


Repository: mesos


Description
-------

We need to return the same `ContainerTermination` result for both
`wait()` and `destroy()` for a terminated container. This patch
ensures that for a terminated nested container `destroy()` returns
the same result as for `wait()`.


Diffs
-----

  src/slave/containerizer/composing.cpp 186102c66d373dcd799cadd9fed7d1c8cb894971 
  src/slave/containerizer/mesos/containerizer.cpp d1d4c2a1781e2011f7ab8feb79f3c5acd2627007



Diff: https://reviews.apache.org/r/66670/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message