mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. (WIP)
Date Tue, 17 Apr 2018 15:23:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66668/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.


Bugs: MESOS-8712
    https://issues.apache.org/jira/browse/MESOS-8712


Repository: mesos


Description
-------

Previously, we were using `destroyed` promise for each container to
guarantee that calling `destroy()` on a container returns a non-empty
value when the destroy-in-progress stops an launch-in-progress using
the next containerizer. Since we are unifying the semantics of the
return type for both `wait()` and `destroy()` operations, we can
remove the `destroyed` promise.


Diffs
-----

  src/slave/containerizer/composing.cpp 186102c66d373dcd799cadd9fed7d1c8cb894971 


Diff: https://reviews.apache.org/r/66668/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message