> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 387-390 (patched)
> > <https://reviews.apache.org/r/66163/diff/3/?file=1996903#file1996903line387>
> >
> > Do you know which targets actually require `ENABLE_GRPC` set as a pre-processor
definition? Since it's new code being added, we should be able to resovle this TODO before
committing.
For now it's just `src/resource_provider/local.cpp`. What's the best way to achieve this?
IMHO it's not that bad to make this global. ;)
> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote:
> > src/resource_provider/storage/CMakeLists.txt
> > Lines 18 (patched)
> > <https://reviews.apache.org/r/66163/diff/3/?file=1996906#file1996906line18>
> >
> > Nit: I've been aligning the `###`... but I know it's that important.
Oops sorry my bad.
> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/CMakeLists.txt
> > Line 237 (original), 250-254 (patched)
> > <https://reviews.apache.org/r/66163/diff/3/?file=1996907#file1996907line250>
> >
> > So `uri_disk_profile_adaptor` is, what, a module? that depends on (and links
in `mesos`), but then `mesos-tess-interface` (which links in `mesos`) also links in `uri_disk_profile_adaptor`.
So if things are being linked statically, `mesos-tests` would then then have `libmesos` twice?
Sorry, I'm just trying to sort out the dependency graph in my head. Can you elaborate?
We have the same dependencies for `load_qos_controller`, `fixed_resource_estimator` and `logrotate_container_logger`
as well. All the four modules depends on `libmesos` apperantly, and `mesos-tests-interface`
also depends on `libmesos`. And since the tests needs these modules, `mesos-tests-interface`
again depends on all of these modules.
I guess we could remove `mesos` above but it looks weird. Also I think there should be no
problem to "link" the same `libmesos` twice. This doesn't violade the one-definition rule.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66163/#review201017
-----------------------------------------------------------
On April 17, 2018, 3:20 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66163/
> -----------------------------------------------------------
>
> (Updated April 17, 2018, 3:20 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
>
>
> Bugs: MESOS-8698
> https://issues.apache.org/jira/browse/MESOS-8698
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds CMake rules for compiling necessary source code for
> building storage local resource provider and related tests.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d
> src/CMakeLists.txt 31af9eaf302122b844e7599944097ad1c3faae3a
> src/examples/CMakeLists.txt e85eed607715d2b3ee596c3c0b51f16682491900
> src/resource_provider/storage/CMakeLists.txt PRE-CREATION
> src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6
>
>
> Diff: https://reviews.apache.org/r/66163/diff/4/
>
>
> Testing
> -------
>
> `sudo make check` with CMake
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
|