mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.
Date Mon, 16 Apr 2018 22:46:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66052/#review201273
-----------------------------------------------------------




include/mesos/master/master.proto
Lines 82-83 (patched)
<https://reviews.apache.org/r/66052/#comment282417>

    Should we make the comments aligned with the above ones?



include/mesos/master/master.proto
Lines 179-188 (patched)
<https://reviews.apache.org/r/66052/#comment282419>

    After rethink about this, the resource itself has a `provide_id` field, so it seems to
me that the `resource_provider_id` is not needed. How about removing `resource_provider_id`
and explaining in the comments that `slave_id` is set if `volume` is a local resource, and
is unset if it is an external resource?
    
    We can always put this field back once when we really need it.



include/mesos/master/master.proto
Lines 198-207 (patched)
<https://reviews.apache.org/r/66052/#comment282420>

    Ditto.



include/mesos/v1/master/master.proto
Lines 177-186 (patched)
<https://reviews.apache.org/r/66052/#comment282421>

    Ditto.



include/mesos/v1/master/master.proto
Lines 196-205 (patched)
<https://reviews.apache.org/r/66052/#comment282422>

    Ditto.


- Chun-Hung Hsiao


On March 28, 2018, 6:28 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66052/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 6:28 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-8747
>     https://issues.apache.org/jira/browse/MESOS-8747
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The same API could be used in the future to grow or shrink CSI volumes,
> but currently only persistent volumes are supported.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto aa63904a33290a3beda162bbc9f44b56ab04a1e7 
>   include/mesos/v1/master/master.proto ddb28f96b2a3a439bb9a829995a9a3015f65ba43 
> 
> 
> Diff: https://reviews.apache.org/r/66052/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message