-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/#review201256
-----------------------------------------------------------
Please document the new metric in `monitoring.md`.
src/master/master.hpp
Lines 2144 (patched)
<https://reviews.apache.org/r/53267/#comment282400>
Nit. This should be in `master.cpp` for consistency with the other gauges.
- James Peach
On April 12, 2018, 9:33 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53267/
> -----------------------------------------------------------
>
> (Updated April 12, 2018, 9:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.
>
>
> Bugs: MESOS-6499
> https://issues.apache.org/jira/browse/MESOS-6499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a gauge to track active subscribers.
>
>
> Diffs
> -----
>
> src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828
> src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2
> src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb
>
>
> Diff: https://reviews.apache.org/r/53267/diff/2/
>
>
> Testing
> -------
>
> Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge
gets updated and new log line is printed.
>
>
> Thanks,
>
> Zhitao Li
>
>
|