mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66050: Implemented grow and shrink of persistent volumes.
Date Mon, 16 Apr 2018 17:38:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review201229
-----------------------------------------------------------




src/master/master.cpp
Lines 4931-4932 (patched)
<https://reviews.apache.org/r/66050/#comment282362>

    I'd change this to:
    
    ```
    "Agent " + stringify(slave) + " does not have the required RESOURCE_PROVIDER capability"
    ```
    
    To be consistent with what `Master::accept()` returns when an operation ID is specified,
but the agent doesn't support `RESOURCE_PROVIDER`.



src/master/master.cpp
Lines 4973 (patched)
<https://reviews.apache.org/r/66050/#comment282363>

    Shouldn't it be `on agent`?



src/master/master.cpp
Lines 5472 (patched)
<https://reviews.apache.org/r/66050/#comment282364>

    I don't think we need to add this line in this patch.
    
    I did notice that we are not consistent in always adding an empty line after the `drop(...)`.
We might want to do a sweep on this function.



src/master/validation.cpp
Lines 2337 (patched)
<https://reviews.apache.org/r/66050/#comment282367>

    We don't normally include the type of operation in the error.
    
    If we do decide to include it for these new operations, I'd write it in upper case.



src/master/validation.cpp
Lines 2348-2351 (patched)
<https://reviews.apache.org/r/66050/#comment282365>

    Isn't it easier to do the following?
    
    ```
    if (growVoluem.addition.scalar.value() <= 0) {
    ...
    ```


- Gaston Kleiman


On April 16, 2018, 10:09 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 10:09 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new offer operations are implemented as speculative operations, but
> we will use validation to make them non-speculative on API level so that
> we can transition later without a breaking change.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 
>   src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
>   src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66050/diff/10/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message