-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66621/#review201171
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66621`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66621
Relevant logs:
- [apply-review-66621-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66621/logs/apply-review-66621-stderr.log):
```
Traceback (most recent call last):
File ".\support\apply-reviews.py", line 447, in <module>
main()
File ".\support\apply-reviews.py", line 442, in main
reviewboard(options)
File ".\support\apply-reviews.py", line 432, in reviewboard
apply_review(options)
File ".\support\apply-reviews.py", line 163, in apply_review
commit_patch(options)
File ".\support\apply-reviews.py", line 292, in commit_patch
shell(cmd, options['dry_run'])
File ".\support\apply-reviews.py", line 147, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Program Files\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Program Files\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Program Files\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 23: ordinal not
in range(128)
```
- Mesos Reviewbot Windows
On April 14, 2018, 10:19 p.m., Clément Michaud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66621/
> -----------------------------------------------------------
>
> (Updated April 14, 2018, 10:19 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: https://issues.apache.org/jira/browse/MESOS-8788
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add alg RS256 support for JWT generator and validator.
>
> Currently, the JWT library only supports unsecured and HS256 tokens. I implemented RS256
to use asymmetrical keys so that Mesos can use it at some point.
>
> https://issues.apache.org/jira/browse/MESOS-8788
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/jwt.hpp 768cbf6fa91537ff9f45f236f4033097c5cea959
> 3rdparty/libprocess/include/process/ssl/utilities.hpp b7cc31c33fd35c93754407f8b350eeb993177f1d
> 3rdparty/libprocess/src/jwt.cpp 921031e6fe3ced5a6be6bc96190fae6d8282ae26
> 3rdparty/libprocess/src/ssl/utilities.cpp 4d3727daf53ec62a19255da5a9804d342e770ec2
> 3rdparty/libprocess/src/tests/jwt_keys.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/jwt_tests.cpp eb36a9aed3b11208c7cdc6f20b5347f46821a207
>
>
> Diff: https://reviews.apache.org/r/66621/diff/1/
>
>
> Testing
> -------
>
> I've added the same tests than the ones for HS256 (i.e., validation in following cases:
bad header, bad payload, unknown alg, unsupported alg, valid token etc.. and creation of a
valid token).
>
>
> Thanks,
>
> Clément Michaud
>
>
|