mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.
Date Sat, 14 Apr 2018 00:25:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66615/#review201146
-----------------------------------------------------------



Thanks for the cleanup!

I think we could get rid of quite some boilerplate with a helper that creates a `ContainerInfo::DockerInfo`.


src/tests/containerizer/docker_containerizer_tests.cpp
Line 265 (original), 260 (patched)
<https://reviews.apache.org/r/66615/#comment282166>

    Nit: I'd add an empty line above this one.
    
    Here and in the other tests.


- Gaston Kleiman


On April 13, 2018, 4:57 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66615/
> -----------------------------------------------------------
> 
> (Updated April 13, 2018, 4:57 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Docker containerizer tests were manually creating the `TaskInfo`
> for the tasks they wanted to launch. We can remove some of that
> boilerplate by adopting the `createTask` helper.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 847258daadf3c37d9071151616b18fc79d850ce8

>   src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e 
> 
> 
> Diff: https://reviews.apache.org/r/66615/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message