mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.
Date Fri, 13 Apr 2018 23:57:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66615/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and Zhitao Li.


Repository: mesos


Description
-------

The Docker containerizer tests were manually creating the `TaskInfo`
for the tasks they wanted to launch. We can remove some of that
boilerplate by adopting the `createTask` helper.


Diffs
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 847258daadf3c37d9071151616b18fc79d850ce8

  src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e 


Diff: https://reviews.apache.org/r/66615/diff/1/


Testing
-------

sudo make check (Fedora 27).


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message