mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66284: Tested `max_completion_time` support in docker executor.
Date Fri, 13 Apr 2018 23:55:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/#review201132
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 646 (patched)
<https://reviews.apache.org/r/66284/#comment282142>

    Use `createTask()` here?
    
    ```
    TaskInfo task = createTask(
        offer.slave_id(),
        offer.resources(),
        SLEEP_COMMAND(1000));
    ```



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 688 (patched)
<https://reviews.apache.org/r/66284/#comment282165>

    Consolidate this into the `EXPECT_CALL` above?


- James Peach


On April 8, 2018, 12:53 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66284/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:53 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested `max_completion_time` support in docker executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 847258daadf3c37d9071151616b18fc79d850ce8

> 
> 
> Diff: https://reviews.apache.org/r/66284/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message