mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66260: Tested `max_completion_time` support in command executor.
Date Fri, 13 Apr 2018 18:31:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66260/#review201124
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/command_executor_tests.cpp
Lines 287 (patched)
<https://reviews.apache.org/r/66260/#comment282112>

    Can you do it like this:
    ```
    EXPECT_CALL(sched, statusUpdate(_, _))
        .WillOnce(FutureArg<1>(&statusStarting))
        .WillOnce(FutureArg<1>(&statusRunning))
        .WillOnce(FutureArg<1>(&statusFailed));
    ```


- James Peach


On April 8, 2018, 12:52 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66260/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:52 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested `max_completion_time` support in command executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/command_executor_tests.cpp 3c5687f918deb8cdda8a97abb0fbd8d9b089926a 
> 
> 
> Diff: https://reviews.apache.org/r/66260/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message