mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP.
Date Fri, 13 Apr 2018 02:40:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66575/
-----------------------------------------------------------

(Updated April 13, 2018, 2:40 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Jie's comment and added checks to ensure the volume state is valid.


Bugs: MESOS-8777
    https://issues.apache.org/jira/browse/MESOS-8777


Repository: mesos


Description
-------

The storage local resource provider now properly calls `NodeStageVolume`
or `NodeUnstageVolume` when publishing or deleting volumes for CSI
plugins support the `STAGE_UNSTAGE_VOLUME` capability.


Diffs (updated)
-----

  src/csi/state.proto a252cb2a38305927304dbf1b5dd81a4f91152cde 
  src/resource_provider/storage/provider.cpp ddbaa0f11309ee97319848cf6601a6cc04cd8147 


Diff: https://reviews.apache.org/r/66575/diff/2/

Changes: https://reviews.apache.org/r/66575/diff/1-2/


Testing
-------

sudo make check

`STAGE_UNSTAGE_VOLUME` is tested later in the chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message