mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.
Date Fri, 13 Apr 2018 01:24:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66418/
-----------------------------------------------------------

(Updated April 13, 2018, 1:24 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-8717
    https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
-------

Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
fails, SLRP assumes the volume states remain unchanged, which are not
suggested by the CSI spec. This patch handles such failures properly.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp 40544e08ab512041640f0f9036f841dbc55e78ca 


Diff: https://reviews.apache.org/r/66418/diff/3/

Changes: https://reviews.apache.org/r/66418/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message