mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.
Date Fri, 13 Apr 2018 00:19:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66229/#review201053
-----------------------------------------------------------



Looks great Kapil - just some minor comments on logging and style.


src/master/master.hpp
Lines 584 (patched)
<https://reviews.apache.org/r/66229/#comment281996>

    Great, I can actually use this right away with some of my work as well - thanks!



src/master/master.cpp
Lines 3440 (patched)
<https://reviews.apache.org/r/66229/#comment282000>

    Which overload are we clashing with here? Or what is the reasoning?
    
    Do you really need the `Master` namespace reference here?



src/master/master.cpp
Lines 3441 (patched)
<https://reviews.apache.org/r/66229/#comment281998>

    Leave the parameter name out for that one, just like the others.



src/master/master.cpp
Lines 3481 (patched)
<https://reviews.apache.org/r/66229/#comment282023>

    If you used `*framework` instead of `frameworkInfo.name()`, the resulting logging could
be even more helpful.



src/master/master.cpp
Lines 3490 (patched)
<https://reviews.apache.org/r/66229/#comment282021>

    See above and remove the leading tick here.



src/master/validation.hpp
Lines 117 (patched)
<https://reviews.apache.org/r/66229/#comment282010>

    s/Valides/Validates/



src/master/validation.cpp
Lines 509 (patched)
<https://reviews.apache.org/r/66229/#comment282038>

    s/frameworkInfos/'FrameworkInfo's/ ?



src/master/validation.cpp
Lines 526 (patched)
<https://reviews.apache.org/r/66229/#comment282027>

    s/newFrameworkInfo.name()/*framework/



src/master/validation.cpp
Lines 532 (patched)
<https://reviews.apache.org/r/66229/#comment282013>

    s/is/are/
    
    How do we make sure the role is "valid" - isn't that implicit when it was contained in
the framework roles?



src/master/validation.cpp
Lines 538 (patched)
<https://reviews.apache.org/r/66229/#comment282014>

    s/suppression/Suppression/



src/master/validation.cpp
Line 538 (original), 597 (patched)
<https://reviews.apache.org/r/66229/#comment282036>

    Thanks, that's better.



src/master/validation.cpp
Lines 712 (patched)
<https://reviews.apache.org/r/66229/#comment282037>

    I really like this new, early specific validation.


- Till Toenshoff


On April 11, 2018, 5:28 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66229/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 5:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented UPDATE_FRAMEWORK call.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
>   src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
>   src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66229/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message