mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 53267: Added a gauge to track active subscribers.
Date Thu, 12 Apr 2018 21:32:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
-----------------------------------------------------------

(Updated April 12, 2018, 2:32 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Changes
-------

Rebase and updated summary.


Summary (updated)
-----------------

Added a gauge to track active subscribers.


Bugs: MESOS-6499
    https://issues.apache.org/jira/browse/MESOS-6499


Repository: mesos


Description (updated)
-------

Added a gauge to track active subscribers.


Diffs (updated)
-----

  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 


Diff: https://reviews.apache.org/r/53267/diff/2/

Changes: https://reviews.apache.org/r/53267/diff/1-2/


Testing
-------

Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge
gets updated and new log line is printed.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message