mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 66408: Updated CSI helpers for v0.2.
Date Thu, 12 Apr 2018 18:54:10 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 12, 2018, 6:54 p.m.)

Review request for mesos, Benjamin Bannier and Jie Yu.


Addressed Jie's comment.

Bugs: MESOS-8717

Repository: mesos


This patch adds new helper classes for CSI plugin and node capabilities,
removed helpers for the removed csi.Version proto message, and makes
the VolumeState proto message uses csi::v0::VolumeCapability.

NOTE: This is not future-proof if there is a breaking change in
VolumeCapability, we might need to change VolumeState to support
multiple CSI versions in the future.

Diffs (updated)

  src/csi/state.hpp dcbc7aba84e0e66dd0e6caf7a64fb95aae69de0a 
  src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
  src/csi/utils.hpp 58b071d4f1512e4cf10d077bd1e03e66626f6dff 
  src/csi/utils.cpp 9e0435762a16f2995bc5a04ec342af6ea231054a 




This patch cannot be compiled standalone. Tests done later in the chain.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message