mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66163: Built storage local resource provider with CMake.
Date Thu, 12 Apr 2018 17:06:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66163/#review201017
-----------------------------------------------------------




cmake/CompilationConfigure.cmake
Lines 387-390 (patched)
<https://reviews.apache.org/r/66163/#comment281948>

    Do you know which targets actually require `ENABLE_GRPC` set as a pre-processor definition?
Since it's new code being added, we should be able to resovle this TODO before committing.



src/CMakeLists.txt
Lines 387-388 (patched)
<https://reviews.apache.org/r/66163/#comment281949>

    :(



src/examples/CMakeLists.txt
Lines 55-59 (patched)
<https://reviews.apache.org/r/66163/#comment281950>

    What about non-Linux but not Windows platforms, e.g. MacOS and FreeBSD?



src/examples/CMakeLists.txt
Lines 93-98 (patched)
<https://reviews.apache.org/r/66163/#comment281951>

    Ditto.



src/examples/CMakeLists.txt
Lines 97 (patched)
<https://reviews.apache.org/r/66163/#comment281952>

    Nit: since it's already out of alignment due to being in a conditional, ther's no need
to add the spaces to try to align `PRIVATE mesos grpc`.



src/resource_provider/storage/CMakeLists.txt
Lines 18 (patched)
<https://reviews.apache.org/r/66163/#comment281953>

    Nit: I've been aligning the `###`... but I know it's that important.



src/tests/CMakeLists.txt
Line 237 (original), 250-254 (patched)
<https://reviews.apache.org/r/66163/#comment281955>

    So `uri_disk_profile_adaptor` is, what, a module? that depends on (and links in `mesos`),
but then `mesos-tess-interface` (which links in `mesos`) also links in `uri_disk_profile_adaptor`.
So if things are being linked statically, `mesos-tests` would then then have `libmesos` twice?
Sorry, I'm just trying to sort out the dependency graph in my head. Can you elaborate?



src/tests/CMakeLists.txt
Lines 337-341 (patched)
<https://reviews.apache.org/r/66163/#comment281954>

    Maybe add a note that this is a binary and that's why it uses `add_dependencies`.


- Andrew Schwartzmeyer


On April 11, 2018, 10:15 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66163/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 10:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
> 
> 
> Bugs: MESOS-8698
>     https://issues.apache.org/jira/browse/MESOS-8698
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds CMake rules for compiling necessary source code for
> building storage local resource provider and related tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/examples/CMakeLists.txt e85eed607715d2b3ee596c3c0b51f16682491900 
>   src/resource_provider/storage/CMakeLists.txt PRE-CREATION 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
> 
> 
> Diff: https://reviews.apache.org/r/66163/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo make check` with CMake
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message