mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 66409: Used `csi::v0::VolumeCapability` in disk profile adaptors.
Date Thu, 12 Apr 2018 16:50:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66409/#review201016
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 3, 2018, 7:18 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66409/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 7:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8717
>     https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To adapt the change in CSI package names (from `csi` to `csi.v0`), we
> now use `csi::v0::VolumeCapability` in the disk profile adaptor module
> interface.
> 
> NOTE: This is not future-proof if there is a breaking change in
> `VolumeCapability`, we might need to change the module interface to
> support multiple CSI versions in the future.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 3a2d86a630fa949df2a5741f12f80fc434407cdc

>   src/resource_provider/storage/disk_profile.proto b9448d7777259b053a62fe2ffe5ae29c9f9be00e

>   src/resource_provider/storage/disk_profile_utils.hpp 9a0a31b48274dfa4d74427aed2a72a4ff245ef7f

>   src/resource_provider/storage/disk_profile_utils.cpp d07c11fdcf7108e1d680f8e2df743426a65331ac

>   src/tests/disk_profile_adaptor_tests.cpp 948f6efc916d6fad0703944ad9acb77d85e4c25e 
> 
> 
> Diff: https://reviews.apache.org/r/66409/diff/1/
> 
> 
> Testing
> -------
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message