mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61096: Building gRPC with CMake.
Date Thu, 12 Apr 2018 16:41:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201007
-----------------------------------------------------------



I want to test on Windows and see if we can get it building there too before giving it a ship-it,
but this looks good!


3rdparty/CMakeLists.txt
Line 143 (original), 144-145 (patched)
<https://reviews.apache.org/r/61096/#comment281940>

    Seems reasonable. Could alternatively setup `ENABLE_GRPC` to set `ENABLE_SSL` (and therefore
also `libevent`?)



3rdparty/CMakeLists.txt
Lines 1012-1015 (patched)
<https://reviews.apache.org/r/61096/#comment281941>

    As stated above, the probably won't work on Windows yet. Ths VS solutions generally stick
everything under `Debug` or `Release` folders, and it's done at build time, not configuration
time. It's super annoying.



3rdparty/CMakeLists.txt
Lines 1022-1027 (patched)
<https://reviews.apache.org/r/61096/#comment281942>

    Do you want the `C` or `CXX` flags forwarded too?


- Andrew Schwartzmeyer


On April 11, 2018, 8:22 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 8:22 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
> 
> 
> Bugs: MESOS-7881
>     https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
>   3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
>   src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc 
> 
> 
> Diff: https://reviews.apache.org/r/61096/diff/6/
> 
> 
> Testing
> -------
> 
> `sudo make check` with CMake
> 
> NOTE: Testing on Windowns is not done yet.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message