mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66457: WIP: Made resource provider API aware of workloads.
Date Thu, 12 Apr 2018 02:12:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66457/#review200959
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66457']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66457

Relevant logs:

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66457/logs/mesos-tests-cmake-stdout.log):

```
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548):
warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\java\mesos-java.vcxproj" (default target) (15) ->
       (ClCompile target) -> 
         d:\dcos\mesos\mesos\include\mesos\resource_provider\resource_provider.hpp(30): error
C3083: 'UpdatePublishResourcesStatus': the symbol to the left of a '::' must be a type (compiling
source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\resource_provider\resource_provider.hpp(30): error
C2039: 'Status': is not a member of 'mesos::resource_provider::Call' (compiling source file
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\resource_provider\resource_provider.hpp(32): error
C3083: 'UpdatePublishResourcesStatus': the symbol to the left of a '::' must be a type (compiling
source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\resource_provider\resource_provider.hpp(32): error
C2039: 'Status_Name': is not a member of 'mesos::resource_provider::Call' (compiling source
file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\v1\resource_provider\resource_provider.hpp(31):
error C3083: 'UpdatePublishResourcesStatus': the symbol to the left of a '::' must be a type
(compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\v1\resource_provider\resource_provider.hpp(31):
error C2039: 'Status': is not a member of 'mesos::v1::resource_provider::Call' (compiling
source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\v1\resource_provider\resource_provider.hpp(33):
error C3083: 'UpdatePublishResourcesStatus': the symbol to the left of a '::' must be a type
(compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\include\mesos\v1\resource_provider\resource_provider.hpp(33):
error C2039: 'Status_Name': is not a member of 'mesos::v1::resource_provider::Call' (compiling
source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) [D:\DCOS\mesos\src\java\mesos-java.vcxproj]

    172 Warning(s)
    8 Error(s)

Time Elapsed 00:07:18.95
```

- Mesos Reviewbot Windows


On April 11, 2018, 2:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66457/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 2:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8760
>     https://issues.apache.org/jira/browse/MESOS-8760
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a breaking change to change `PublishResources` to
> `UpdateResourceUsage`, so the resource provider is aware of workloads.
> For local resource providers, a workload is a container, and this call
> is responsible to prepare the resources for each container. For external
> resource providers, a workload is a framework, so this call can bookkeep
> the resource usage for each framework and inform the allocator after a
> failover.
> 
> Note that this call is designed to report ALL resources used by every
> workload on an agent, so it can handle resources without identifiers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto db7c751bb61fb1ee2421015dcbefc021c3afbdac

>   include/mesos/v1/resource_provider/resource_provider.proto 42bc050ed01a272603a41ab052ed75d799dd76e2

> 
> 
> Diff: https://reviews.apache.org/r/66457/diff/2/
> 
> 
> Testing
> -------
> 
> This patch cannot be compiled standalone. Tests will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message