mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66493: Made FreeBSD default to non-GNU ld.
Date Wed, 11 Apr 2018 23:38:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review200945
-----------------------------------------------------------


Fix it, then Ship it!





cmake/CompilationConfigure.cmake
Lines 322 (patched)
<https://reviews.apache.org/r/66493/#comment281866>

    (Nit: I wouldn't even bother with this doc string. "Linker path." is pointless, but so
is explaining it, especially considering the comment above and the error message below, and
the variable name itself.)



cmake/CompilationConfigure.cmake
Lines 330-332 (patched)
<https://reviews.apache.org/r/66493/#comment281867>

    Nit: No real reason to set `USE_LD_FLAG` since it's used once. `string(APPEND CMAKE_${type}_LINKER_FLAGS
" -fuse-ld=${LD_PROGRAM}")` should be just fine.


- Andrew Schwartzmeyer


On April 9, 2018, 11:36 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66493/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8761
>     https://issues.apache.org/jira/browse/MESOS-8761
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made FreeBSD default to non-GNU ld.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
> 
> 
> Diff: https://reviews.apache.org/r/66493/diff/2/
> 
> 
> Testing
> -------
> 
> make on FreeBSD, with both lld and gold.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message