mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 66553: Restructured Web UI.
Date Wed, 11 Apr 2018 22:36:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66553/#review200940
-----------------------------------------------------------


Ship it!




A little bit of history, "master" was there because the agent used to serve its own UI and
the master would link to that :)

- Benjamin Mahler


On April 11, 2018, 3:21 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66553/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 3:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-8503
>     https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Does not change the logic of the Web UI, only updates the structure
> to have fewer nested directories and a more logical grouping of files.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
>   src/webui/master/static/agent.html  
>   src/webui/master/static/agent_executor.html  
>   src/webui/master/static/agent_framework.html  
>   src/webui/master/static/agents.html  
>   src/webui/master/static/browse.html  
>   src/webui/master/static/css/bootstrap-3.3.6.min.css  
>   src/webui/master/static/css/bootstrap-table-1.11.1.min.css  
>   src/webui/master/static/css/mesos.css  
>   src/webui/master/static/directives/pagination.html  
>   src/webui/master/static/directives/tableHeader.html  
>   src/webui/master/static/directives/timestamp.html  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.eot  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.svg 94fb5490a2ed10b2c69a4a567a4fd2e4f706d841

>   src/webui/master/static/fonts/glyphicons-halflings-regular.ttf  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff2  
>   src/webui/master/static/framework.html  
>   src/webui/master/static/frameworks.html  
>   src/webui/master/static/home.html  
>   src/webui/master/static/ico/favicon.ico  
>   src/webui/master/static/img/loading.gif  
>   src/webui/master/static/img/mesos_logo.png  
>   src/webui/master/static/index.html 149d765429dc2211875783129da6c6b101f38ecf 
>   src/webui/master/static/js/angular-1.2.32.min.js  
>   src/webui/master/static/js/angular-route-1.2.32.min.js  
>   src/webui/master/static/js/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
>   src/webui/master/static/js/bootstrap-table-1.11.1.min.js  
>   src/webui/master/static/js/clipboard-1.5.16.min.js  
>   src/webui/master/static/js/controllers.js 66a4f2955a88fa44c3e5c717e9ce6b680050cc34

>   src/webui/master/static/js/jquery-3.2.1.min.js  
>   src/webui/master/static/js/jquery.pailer.js  
>   src/webui/master/static/js/relative-date.js  
>   src/webui/master/static/js/services.js  
>   src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js  
>   src/webui/master/static/js/underscore-1.4.3.min.js  
>   src/webui/master/static/maintenance.html  
>   src/webui/master/static/offers.html  
>   src/webui/master/static/pailer.html 6710b7d4405d66171d07e88112c71bb4a30b29d4 
>   src/webui/master/static/roles.html  
> 
> 
> Diff: https://reviews.apache.org/r/66553/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> GTEST_FILTER="" make check -j4
> ```
> And tested manually.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message