mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 66538: Added unit test slave recovery for default executor tests.
Date Wed, 11 Apr 2018 18:53:06 GMT


> On April 11, 2018, 7:14 a.m., Qian Zhang wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1427-1430 (patched)
> > <https://reviews.apache.org/r/66538/diff/1/?file=1995305#file1995305line1427>
> >
> >     Why do we need to launch the executor using reserved resources? This seems not
relevant to the target of this test. I think we can just launch both the executor and the
task with unreserved resources.

Ah, my mistake by copying from the test above. Thanks!


> On April 11, 2018, 7:14 a.m., Qian Zhang wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1481-1485 (patched)
> > <https://reviews.apache.org/r/66538/diff/1/?file=1995305#file1995305line1481>
> >
> >     So we use this as a signal that the default executor has re-registered with
the agent, right? But I think this `TASK_RUNNING` status update will actually be resent by
the agent (rather than the executor) after the agent re-registered with the master and even
before the executor re-registered with the agent. So I think it might not be used as such
signal.

Ah, good catch. we could not verified the executor reregistration due to MESOS-6623


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66538/#review200891
-----------------------------------------------------------


On April 10, 2018, 4:41 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66538/
> -----------------------------------------------------------
> 
> (Updated April 10, 2018, 4:41 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8772
>     https://issues.apache.org/jira/browse/MESOS-8772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test slave recovery for default executor tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66538/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message