mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.
Date Wed, 11 Apr 2018 13:36:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66546/#review200906
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66308', '66309', '66526', '66310', '66311', '66544', '66545', '66546']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546/logs/mesos-tests-stdout.log):

```
[ RUN      ] ProtobufIOTest.RepeatedPtrField
[       OK ] ProtobufIOTest.RepeatedPtrField (5 ms)
[----------] 3 tests from ProtobufIOTest (66 ms total)

[----------] 4 tests from ResourceOffersTest
[ RUN      ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops
[       OK ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops (219 ms)
[ RUN      ] ResourceOffersTest.ResourcesGetReofferedWhenUnused
[       OK ] ResourceOffersTest.ResourcesGetReofferedWhenUnused (217 ms)
[ RUN      ] ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError
[       OK ] ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError (228 ms)
[ RUN      ] ResourceOffersTest.Request
[       OK ] ResourceOffersTest.Request (88 ms)
[----------] 4 tests from ResourceOffersTest (786 ms total)

[----------] 4 tests from ResourceProviderManagerHttpApiTest
[ RUN      ] ResourceProviderManagerHttpApiTest.NoContentType
[       OK ] ResourceProviderManagerHttpApiTest.NoContentType (6 ms)
[ RUN      ] ResourceProviderManagerHttpApiTest.ValidJsonButInvalidProtobuf
[       OK ] ResourceProviderManagerHttpApiTest.ValidJsonButInvalidProtobuf (9 ms)
[ RUN      ] ResourceProviderManagerHttpApiTest.ResourceProviderSubscribeDisconnect
[       OK ] ResourceProviderManagerHttpApiTest.ResourceProviderSubscribeDisconnect (240 ms)
[ RUN      ] ResourceProviderManagerHttpApiTest.Metrics
[       OK ] ResourceProviderManagerHttpApiTest.Metrics (283 ms)
[----------] 4 tests from ResourceProviderManagerHttpApiTest (565 ms total)

[----------] 2 tests from ResourceProviderRegistrarTest
[ RUN      ] ResourceProviderRegistrarTest.AgentRegistrar
d:\dcos\mesos\mesos\src\tests\resource_provider_manager_tests.cpp(846): error: Failed to wait
15secs for admitResourceProvider1
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546/logs/mesos-tests-stderr.log):

```
I0411 13:35:46.470496 22996 master.cpp:1295] Agent b06ec2bf-76ea-4418-ad7b-a3e511926895-S0
at slave(95)@10.3.1.8:61057 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0411 13:35:46.470496 22996 master.cpp:3286] Disconnecting agent b06ec2bf-76ea-4418-ad7b-a3e511926895-S0
at slave(95)@10.3.1.8:61057 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0411 13:35:46.470496 22996 master.cpp:3305] Deactivating agent b06ec2bf-76ea-4418-ad7b-a3e511926895-S0
at slave(95)@10.3.1.8:61057 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0411 13:35:46.470496 14112 hierarchical.cpp:766] Agent b06ec2bf-76ea-4418-ad7b-a3e511926895-S0
deactivated
I0411 13:35:46.492497 16128 master.cpp:1137] Master terminating
I0411 13:35:46.495492  9888 hierarchical.cpp:609] Removed agent b06ec2bf-76ea-4418-ad7b-a3e511926895-S0
[libprotobuf FATAL d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\message_lite.cc:281]
CHECK failed: IsInitialized(): Can't serialize message of type "mesos.resource_provider.registry.Registry"
because it is missing required fields: resource_providers[0].info.type, resource_providers[0].info.name
*** Check failure stack trace: ***
    @   00007FF642FF0DEB  google::LogMessage::Fail
    @   00007FF642FF0CF1  google::LogMessage::SendToLog
    @   00007FF642FF04D7  google::LogMessage::Flush
    @   00007FF642FF2011  google::LogMessageFatal::~LogMessageFatal
    @   00007FF6444BE95E  `process::ProcessManager::resume'::`1'::catch$11
    @   00007FFBC01D14F0  __C_specific_handler
    @   00007FFBC01D53FA  __BuildCatchObjectHelper
    @   00007FFBCFEE4203  RtlCaptureContext
    @   00007FF6429B1C20  process::ProcessManager::resume
    @   00007FF642ABCD61   ?? 
    @   00007FF6429F9D90  std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7>
>
    @   00007FF642A501C0  std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
    @   00007FF642A08A3C  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Execute<0>
    @   00007FF642B0813A  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Run
    @   00007FF642AF4B98  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Go
    @   00007FF642ADCDDD  std::_Pad::_Call_func
    @   00007FFBB65F11E8  _register_onexit_function
    @   00007FFBB65F0E01  _register_onexit_function
    @   00007FFBCFD71FE4  BaseThreadInitThunk
    @   00007FFBCFEAEFC1  RtlUserThreadStart
F0411 13:35:46.534499 14244 process.cpp:2985] Aborting libprocess: 'resource-provider-agent-registrar(85)@10.3.1.8:61057'
threw exception: CHECK failed: IsInitialized(): Can't serialize message of type "mesos.resource_provider.registry.Registry"
because it is missing required fields: resource_providers[0].info.type, resource_providers[0].info.name
```

- Mesos Reviewbot Windows


On April 11, 2018, 9:32 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66546/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 9:32 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-7558
>     https://issues.apache.org/jira/browse/MESOS-7558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a check to the resource provider manager's subscribe
> functionality making sure that any the ID sent by a resubscribing
> resource provider corresponds to some previously known resource
> provider.
> 
> This not only serves as convenient validation of user-provided data,
> but also makes sure that the internal state of the resource provider
> manager remains consistent.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea

> 
> 
> Diff: https://reviews.apache.org/r/66546/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message