-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66460/#review200842
-----------------------------------------------------------
include/mesos/v1/scheduler.hpp
Lines 102-114 (patched)
<https://reviews.apache.org/r/66460/#comment281746>
Hm.. why does this return an `Option<Response>`?
If this is mesos Response rather than http::Response, aren't we losing information about
which http code came back? (e.g. 400, 401, etc).
- Benjamin Mahler
On April 6, 2018, 9:17 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66460/
> -----------------------------------------------------------
>
> (Updated April 6, 2018, 9:17 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `call()` method to the scheduler library that allows
> clients to send a `v1::scheduler::Call` to the master and receive a
> `v1::scheduler::Response`.
>
> It is going to be used to test operation state reconciliation.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp d56e08861d5190ef66992d383dc5710d8f6ce661
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 60b17b9be74132c81532d22eba681feb899b22a3
> src/scheduler/scheduler.cpp ecef916ffd0797a13552525ff2cda0f99ca57e74
>
>
> Diff: https://reviews.apache.org/r/66460/diff/3/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
|