mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66489: Cleaned up internal evolve functions.
Date Tue, 10 Apr 2018 18:39:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66489/#review200833
-----------------------------------------------------------


Fix it, then Ship it!





src/internal/evolve.hpp
Line 152 (original), 152-153 (patched)
<https://reviews.apache.org/r/66489/#comment281737>

    Can we get rid of the `mesos::` here as well?


- Greg Mann


On April 7, 2018, 12:16 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66489/
> -----------------------------------------------------------
> 
> (Updated April 7, 2018, 12:16 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes the `mesos::` prefix from declarations where
> possible, uses a consistent number of empty lines in the header,
> and reorders some declarations.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp e00ac7175438f758b10c0aa9485fc29ffa4efa29 
>   src/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67 
> 
> 
> Diff: https://reviews.apache.org/r/66489/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message