mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66311: Implement recovery of resource provider manager.
Date Tue, 10 Apr 2018 15:27:21 GMT


> On April 10, 2018, 3:05 p.m., Jan Schlicht wrote:
> >

Thank you for your comments. I have some issues updating the patch in reviewboard at this
time, will retry later. Please see my responses below.


> On April 10, 2018, 3:05 p.m., Jan Schlicht wrote:
> > src/resource_provider/manager.cpp
> > Lines 201 (patched)
> > <https://reviews.apache.org/r/66311/diff/2/?file=1994129#file1994129line202>
> >
> >     Unnecessary namespaces, as `Registry` is in scope here. Here and in the implementation
below.

This _is_ needed due to ADL -- as `ResourceProviderManagerProcess` is defined in `mesos::internal`,
just `Registry` would resolve to `mesos::internal::Registry` here. Dropping.


> On April 10, 2018, 3:05 p.m., Jan Schlicht wrote:
> > src/resource_provider/registrar.cpp
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/66311/diff/2/?file=1994131#file1994131line97>
> >
> >     `Registry` is in scope here and used without the namespace in other parts of
this unit. Let's be consistent and drop the namespace here and below.

See above. Dropping.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66311/#review200734
-----------------------------------------------------------


On April 10, 2018, 2:07 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66311/
> -----------------------------------------------------------
> 
> (Updated April 10, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
>     https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adjusts the control flow of the resource provider manager
> so that we can in the future make use of persisted resource provider
> information.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 2d3ffcdd01671f81729fe538348f2ca4e555eb4f 
>   src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 9eb49f1327a0b598c5464a29a09ee286d7018f09 
>   src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea

> 
> 
> Diff: https://reviews.apache.org/r/66311/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message