mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66309: Externalize creation of resource provider manager backing storage.
Date Tue, 10 Apr 2018 12:08:02 GMT


> On March 28, 2018, 3:30 p.m., Jan Schlicht wrote:
> > src/resource_provider/registrar.hpp
> > Lines 68-69 (original), 70-71 (patched)
> > <https://reviews.apache.org/r/66309/diff/1/?file=1989033#file1989033line70>
> >
> >     I don't like the semantics of this:
> >     A `state::Storage` doesn't provide any information if it belongs to master or
agent but we instantiate an `AgentRegistrar` anyways.
> >     
> >     Hence, please rename `AgentRegistrar` to something more general that indicates
that this isn't tied to an agent state.

That makes much sense. I have added a follow up patch to address this to not put too many
changes into this one, https://reviews.apache.org/r/66526/.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66309/#review200105
-----------------------------------------------------------


On April 10, 2018, 2:07 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66309/
> -----------------------------------------------------------
> 
> (Updated April 10, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
>     https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the way the storage backing an agent's resource
> provider registrar is created: while before we created it implicitly
> when constructing the registrar, we now consume storage passed on
> construction.
> 
> Being able to explicitly inject the used storage simplifies testing.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 9eb49f1327a0b598c5464a29a09ee286d7018f09 
>   src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea

> 
> 
> Diff: https://reviews.apache.org/r/66309/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message