mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66464: Implemented operation status reconciliation.
Date Mon, 09 Apr 2018 19:31:16 GMT


> On April 9, 2018, 12:04 p.m., Greg Mann wrote:
> > src/master/http.cpp
> > Lines 5097 (patched)
> > <https://reviews.apache.org/r/66464/diff/1/?file=1992581#file1992581line5102>
> >
> >     s/reconcileOperations/std::move(reconcileOperations)/

Do you think that we need to use std::move to cast it as an rvalue?


It is already an rvalue per the method signature:

```
Future<Response> Master::Http::reconcileOperations(
    scheduler::Response::ReconcileOperations&& reconcileOperations,
    ContentType contentType) const
```


> On April 9, 2018, 12:04 p.m., Greg Mann wrote:
> > src/master/master.hpp
> > Lines 2556 (patched)
> > <https://reviews.apache.org/r/66464/diff/1/?file=1992582#file1992582line2556>
> >
> >     A return type of `Try<Operation*>` seems semanticallly more appropriate
here?
> >     
> >     Also, let's pass the id as a const ref.

I agree that id should be const OperationID&.


Regarding returning a Try, what error would it return? I see this as semantically equivalent
to a get method on a hashmap, so an Option seems to be a better fit.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review200680
-----------------------------------------------------------


On April 4, 2018, 5:47 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66464/
> -----------------------------------------------------------
> 
> (Updated April 4, 2018, 5:47 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented operation status reconciliation.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
> 
> 
> Diff: https://reviews.apache.org/r/66464/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> https://reviews.apache.org/r/66468/ adds new tests.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message