mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66464: Implemented operation status reconciliation.
Date Mon, 09 Apr 2018 19:26:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review200746
-----------------------------------------------------------




src/master/http.cpp
Lines 5097 (patched)
<https://reviews.apache.org/r/66464/#comment281596>

    Do you think that we need to use `std::move` to cast it as an rvalue?
    
    It is already an rvalue per the method signature:
    
    ```
    Future<Response> Master::Http::reconcileOperations(
        scheduler::Response::ReconcileOperations&& reconcileOperations,
        ContentType contentType) const
    ```



src/master/master.hpp
Lines 2556 (patched)
<https://reviews.apache.org/r/66464/#comment281597>

    I agree that `id` should be `const OperationID&`.
    
    Regarding returning a `Try`, what error would it return? I see this as semantically equivalent
to a get method on a hashmap, so an `Option` seems to be a better fit.


- Gaston Kleiman


On April 4, 2018, 5:47 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66464/
> -----------------------------------------------------------
> 
> (Updated April 4, 2018, 5:47 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented operation status reconciliation.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
> 
> 
> Diff: https://reviews.apache.org/r/66464/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> https://reviews.apache.org/r/66468/ adds new tests.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message