mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.
Date Mon, 09 Apr 2018 15:44:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66510/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.


Bugs: MESOS-8706
    https://issues.apache.org/jira/browse/MESOS-8706


Repository: mesos


Description
-------

This patch changes the return type of `destroy()` method for all
containerizers. As a result, `destroy()` and `wait()` methods have
got the same signature and return type. In fact, all these methods
depend on the same container termination promise, so this unification
makes both containerizer interface and internal logic more consistent.


Diffs
-----

  src/slave/containerizer/composing.hpp 1221d9b61b7cfbdbaa560dbafb0158225331ed6d 
  src/slave/containerizer/composing.cpp cd840a5409023d32701329bf37806f2e7ed6ffd2 
  src/slave/containerizer/containerizer.hpp 836283aa8aa827459558d567e090a230c32351ed 
  src/slave/containerizer/docker.hpp f1b56c8edced17e9786c86adb9b92c829ed81635 
  src/slave/containerizer/docker.cpp 31d64a7ea2a331a084c0f1707b82e938dfe6390f 
  src/slave/containerizer/mesos/containerizer.hpp cba4ed2e20622070b46071f35907d8b32c25b2fc

  src/slave/containerizer/mesos/containerizer.cpp 7473a871e626833733f39375b778aff70529dc63

  src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd 


Diff: https://reviews.apache.org/r/66510/diff/1/


Testing
-------

Tests can't be compiled after this change.
See the next patch in the chain.


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message