mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 66508: Made sure test agent has reached stable state before starting test.
Date Mon, 09 Apr 2018 14:07:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66508/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Repository: mesos


Description
-------

We require a certain number of offers in
`SlaveTest.ResourceProviderPublishAll`, so we need to make sure that
the agent knows all resources available during the test before offers
are being generated.

In this patch we await all `UpdateSlaveMessage` from the agent to make
sure the agent has seen all resources. Only then do we register a
framework. This greatly minimizes the risk of not seeing the expected
number of offers which now should only happen if due to
master-internal message reordering the allocator sees the framework
before it sees the latest agent resource update.


Diffs
-----

  src/tests/slave_tests.cpp 646a2b9e046fb37dbe0610ea0848b50192913deb 


Diff: https://reviews.apache.org/r/66508/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message