mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66493: Made FreeBSD default to non-GNU ld.
Date Mon, 09 Apr 2018 13:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review200725
-----------------------------------------------------------




cmake/CompilationConfigure.cmake
Lines 308-311 (patched)
<https://reviews.apache.org/r/66493/#comment281567>

    I was briefly wondering why we checked for clang below. The reason is of course that cmake
by default uses the compiler as linker, and there is an incompatibility on FreeBSD when compiling
with clang and linking with `ld.bfd`.
    
    I think it would be useful to describe this in more detail here so we have a chance to
understand when this check can go in the future. Ideally we'd be able to link some upstream
issue, but it may not exist.



cmake/CompilationConfigure.cmake
Lines 315 (patched)
<https://reviews.apache.org/r/66493/#comment281581>

    This conditional seems not needed as cmake will automatically detect if `LD_PROGRAM` was
set by the user. Is this a variable we should document as a customization point?



cmake/CompilationConfigure.cmake
Lines 318 (patched)
<https://reviews.apache.org/r/66493/#comment281582>

    Since this variable will be setable from the outside _Alternative_ seems redundant here.



cmake/CompilationConfigure.cmake
Lines 322 (patched)
<https://reviews.apache.org/r/66493/#comment281568>

    Could we make clearer what a user needs to do to have this check pass? The error message
appears too technical to me.



cmake/CompilationConfigure.cmake
Lines 326-329 (patched)
<https://reviews.apache.org/r/66493/#comment281583>

    I am not sure this is an issue, but customary there are similar variables defined for
other build types like `DEBUG`, `RELEASE`, etc. (e.g., `CMAKE_EXE_LINKER_FLAGS_DEBUG`).
    
    Do we have something to set all related flags @andschwa?


- Benjamin Bannier


On April 7, 2018, 4:54 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66493/
> -----------------------------------------------------------
> 
> (Updated April 7, 2018, 4:54 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8761
>     https://issues.apache.org/jira/browse/MESOS-8761
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made FreeBSD default to non-GNU ld.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
> 
> 
> Diff: https://reviews.apache.org/r/66493/diff/1/
> 
> 
> Testing
> -------
> 
> make on FreeBSD, with both lld and gold.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message