mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66311: Implement recovery of resource provider manager.
Date Mon, 09 Apr 2018 10:29:51 GMT


> On April 6, 2018, 4:22 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.cpp
> > Lines 261-263 (patched)
> > <https://reviews.apache.org/r/66311/diff/1/?file=1989040#file1989040line262>
> >
> >     The used endpoint detector currently cannot deal with this which can e.g., lead
to failed resource provider subscribes in production or test code.

Addressed by blocking any API call until the RP manager has finished recovery. This appears
okay as recovery is started automatically when the manager is constructed.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66311/#review200650
-----------------------------------------------------------


On April 9, 2018, 12:29 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66311/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 12:29 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
>     https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adjusts the control flow of the resource provider manager
> so that we can in the future make use of persisted resource provider
> information.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 2d3ffcdd01671f81729fe538348f2ca4e555eb4f 
>   src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 9eb49f1327a0b598c5464a29a09ee286d7018f09 
>   src/tests/resource_provider_manager_tests.cpp 05ae5defb986103520cf630d5578e8a04e662313

> 
> 
> Diff: https://reviews.apache.org/r/66311/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message